You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was recently re-reminded that __has_extension isn't the best/right way to test for this (per @zygoloid's Dec 2021 comment in https://reviews.llvm.org/D114732#3165581 ). I suggest either removing this codepath entirely or replacing it with one of the P1144R9 feature-test macros:
Note that Clang trunk's __is_trivially_relocatable(T) builtin is still not usable for your purposes (i.e., llvm/llvm-project#84621 still isn't moving), so this codepath is still relevant only to the P1144 reference implementation on Godbolt.
https://github.com/chromium/subspace/blob/f9c481a241961a7be827d31fadb01badac6ee86a/sus/mem/relocate.h#L60C7-L60C45
I was recently re-reminded that
__has_extension
isn't the best/right way to test for this (per @zygoloid's Dec 2021 comment in https://reviews.llvm.org/D114732#3165581 ). I suggest either removing this codepath entirely or replacing it with one of the P1144R9 feature-test macros:(almost certainly the best option)
or (IMHO a worse option)
Note that Clang trunk's
__is_trivially_relocatable(T)
builtin is still not usable for your purposes (i.e., llvm/llvm-project#84621 still isn't moving), so this codepath is still relevant only to the P1144 reference implementation on Godbolt.attn: @danakj
The text was updated successfully, but these errors were encountered: