Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New exit code for timeout #864

Open
akshay-xp opened this issue Nov 29, 2023 · 1 comment
Open

New exit code for timeout #864

akshay-xp opened this issue Nov 29, 2023 · 1 comment
Assignees
Labels
customer reported Tracking: This issue was reported through customer support enhancement Classification: New feature or request

Comments

@akshay-xp
Copy link

Feature request

Introduce a new exit code specifically dedicated to timeouts.

Proposed solution

Provide users with a distinct identifier for processes that conclude due to elapsed time constraints. This enhancement streamlines error diagnostics and facilitates more precise troubleshooting in time-sensitive scenarios.

Alternative solutions

Introduce a descriptive error message signaling a build timeout, enhancing user visibility and troubleshooting capabilities when time limits are exceeded during the build process. This straightforward notification ensures users are promptly informed about the specific cause of the interruption.

Additional context
When building Storybook using storybook build, the process runs smoothly without any issues. However, when using Chromatic for the build, it unexpectedly exits with code 105, causing confusion. After thorough investigation, I discovered that increasing the build timeout time using STORYBOOK_BUILD_TIMEOUT resolved the issue. FYI, my Storybook includes 1100+ stories and 400+ components.

using,
Node : 18.17.1
npm: 9.6.7
Yarn: 1.22.19
@storybook/react: 7.4.5 + @storybook/react-webpack5: 7.4.5
chromatic: 9.1.0

the image below is from Gitlab CI

image

@akshay-xp akshay-xp added the needs triage Tracking: Issue needs confirmation label Nov 29, 2023
@ghengeveld
Copy link
Member

Happy to accept a PR for this if you're able and willing. Otherwise this will end up on the backlog which means it may take a while for us to get to it.

@jmhobbs jmhobbs added enhancement Classification: New feature or request customer reported Tracking: This issue was reported through customer support and removed needs triage Tracking: Issue needs confirmation labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer reported Tracking: This issue was reported through customer support enhancement Classification: New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants