Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locally accepted baselines not carried over when switching branch #249

Open
ghengeveld opened this issue Mar 22, 2024 · 1 comment
Open
Labels
feature Classification: New feature

Comments

@ghengeveld
Copy link
Member

ghengeveld commented Mar 22, 2024

From AP-4356

How is the user affected? And what is the expected behavior?

Locally accepted snapshots are supposed to be promoted to project-wide baselines when the local author pushes a commit that runs a CI build. However, when the local builds ran on a different branch, those accepted changes don't carry over and need to be reviewed again.

How many and/or what class of users does this impact?

Users that make local changes, accept VTA builds and then switch branch before committing.

Is there a workaround?

Switch branch before running any local VTA builds.

What are the steps for reproducing the issue?

On main, make some visual changes, run some builds and accept the changes locally. Create a new branch and commit your work. Push the changes to trigger a CI build. This build will resurface all changes that were previously accepted on the local build.

@ghengeveld
Copy link
Member Author

This is related to, but not the same as #259.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Classification: New feature
Projects
None yet
Development

No branches or pull requests

2 participants