Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromatic configuration messaging improvements #242

Open
ghengeveld opened this issue Mar 22, 2024 · 1 comment
Open

Chromatic configuration messaging improvements #242

ghengeveld opened this issue Mar 22, 2024 · 1 comment
Labels
bug Classification: Something isn't working sev:S3

Comments

@ghengeveld
Copy link
Member

ghengeveld commented Mar 22, 2024

From AP-4272

How is the user affected? And what is the expected behavior?

After doing some additional QA based on AP-4201 I noticed a couple of items that require some polish to unblock users and avoid misconceptions:

  1. When a user extends the Visual tests addon configuration as mentioned in the linked ticket, Storybook will break the build and stop it immediately as seen below.

image

Since the addon is now tied to Storybook, the message does not provide clarity nor point at a place where a user should look for information on what's happening, or how to solve this issue. We can mitigate this by:

  • Add a link to the appropriate section in the Visual tests page
  • On the documentation front, change from details element into a proper heading to make it more discoverable (more even as the generated link does not work).
  1. For the UI aspect, the messaging also needs to be updated as the instructions that are available to the user don't provide clarity and are misleading him/her on the steps needed and leaves the user in an inconsistent state where he/she doesn't know what to do in this situation as captured below
Chromatic.config.UI.issue.mp4

I was able to solve this via restarting Storybook, but we can not guarantee that our users will have the same thinking process and may start jumping into the support channels (e.g., Intercom, Storybook's discussions, or the issue tracker) and start asking questions that could have been avoided.

  1. The CLI is too eager on showing the error message regarding the configuration, which can cause yet more misconceptions from the user's part. Specifically after the user finishes the auth process and jumps into the project selection, as there's no configuration file, or project connected to the addon, it throws the error message and leaves the CLI in the following state
Chromatic.CLI.issue.mp4

For this specific item, if we're unable to address it in a good way, we can at least mitigate it with type of message that avoids this scenario.

cc @winkerVSbecks

@ghengeveld ghengeveld added documentation Classification: Changes only affect the documentation sev:S4 labels Mar 22, 2024
@jonniebigodes
Copy link
Contributor

Comment from mentioned ticket

I just tested a custom file location for the config and it worked successfully from 8.x. Also, if I cannot find the file, this error message throws and the SB CLI exits early. We can improve this message further, if you have suggestions. Yet, this seems to be resolved otherwise.

via @thafryer

@ghengeveld ghengeveld added bug Classification: Something isn't working sev:S3 and removed documentation Classification: Changes only affect the documentation sev:S4 labels May 19, 2024
@ghengeveld ghengeveld added this to the post-launch stabilization milestone May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working sev:S3
Projects
None yet
Development

No branches or pull requests

2 participants