Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Anchors in links to docs.trychroma.com don't work #3395

Closed
tazarov opened this issue Jan 3, 2025 · 4 comments · Fixed by #3411
Closed

[Bug]: Anchors in links to docs.trychroma.com don't work #3395

tazarov opened this issue Jan 3, 2025 · 4 comments · Fixed by #3411
Labels
bug Something isn't working by-chroma documentation Improvements or additions to documentation

Comments

@tazarov
Copy link
Contributor

tazarov commented Jan 3, 2025

What happened?

When trying to navigate to a doc site link with anchor like so https://docs.trychroma.com/reference/python/client#deletecollection the anchor is removed and the user is never taken to the heading.

Versions

N/A

Relevant log output

No response

@tazarov tazarov added bug Something isn't working documentation Improvements or additions to documentation by-chroma labels Jan 3, 2025
@tazarov tazarov changed the title [Bug]: Anchors in doc site links don't work [Bug]: Anchors in links to docs.trychroma.com don't work Jan 3, 2025
@itaismith itaismith reopened this Jan 3, 2025
@ahmedaabouzied
Copy link
Contributor

I observed that the anchors take the user to the heading in Firefox, but in Chrome it does not.

In both cases though, the anchor is removed from the URL.

@tazarov
Copy link
Contributor Author

tazarov commented Jan 6, 2025

@ahmedaabouzied, thanks for confirming this. It would appear that a js code removes the anchors when the site is first loaded. I'll also do some digging around this.

ahmedaabouzied added a commit to ahmedaabouzied/chroma that referenced this issue Jan 6, 2025
- Closes chroma-core#3395
- Also removes the not used useContext react import.

Signed-off-by: Ahmed Abouzied <[email protected]>
@ahmedaabouzied
Copy link
Contributor

ahmedaabouzied commented Jan 6, 2025

I think it is the redirection layer to either the python or JS docs. I opened a PR.
Could you check it out when you have the time?

These things are hard to unit test. I simply ran it locally.

@tazarov
Copy link
Contributor Author

tazarov commented Jan 6, 2025

@ahmedaabouzied, PR looks good. Did some local tests and fixed an issue, directly pushed against your fork, hope it is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working by-chroma documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants