Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation used to update pace and OR dataframe values #8

Open
kyle1 opened this issue Apr 22, 2019 · 0 comments
Open

Calculation used to update pace and OR dataframe values #8

kyle1 opened this issue Apr 22, 2019 · 0 comments

Comments

@kyle1
Copy link

kyle1 commented Apr 22, 2019

Regarding the following line in update_df:

new_value = (float(old_value) + float(value)) / 2

Am I understanding this correctly that this calculation means the most-recent games are more heavily weighted in the resulting matrices? Team A can have an average offensive rating of 90 vs Team B over 6 games. If Team A then has an offensive rating of 110 against Team B in their 7th meeting, the matrix will now have the value (90+110) / 2 = 100 even though their actual season average vs Team B is ~93.

Is this intentional (or am I missing something)? I'd assume a true average would be more preferable than the above case. I'm not sure if there's a simple way to track the number of updates to each value to achieve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant