Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting an event in Civi does not delete corresponding event in EO #29

Open
kurund opened this issue Jan 20, 2021 · 5 comments
Open

Deleting an event in Civi does not delete corresponding event in EO #29

kurund opened this issue Jan 20, 2021 · 5 comments

Comments

@kurund
Copy link

kurund commented Jan 20, 2021

Current Behavior

  • When you delete an event in Civi it does not delete the corresponding event in EO

Expected Behavior

  • When event is deleted in Civi, it should delete an event in EO
@kurund kurund changed the title Deleting an event in Civi does not delete post in EO Deleting an event in Civi does not delete corresponding event in EO Jan 20, 2021
@christianwach
Copy link
Owner

@kurund I think this has been discussed elsewhere and it was decided not to delete the EO event because there may be unintended data loss. Similar logic was thought through in the reverse direction too. See:

https://github.com/christianwach/civicrm-event-organiser/blob/master/includes/civicrm-event-organiser-eo.php#L292-L302

And:

https://github.com/christianwach/civicrm-event-organiser/blob/master/includes/civicrm-event-organiser-eo.php#L324-L331

If that is your desired behaviour, it's simple to do so in a separate plugin.

@christianwach
Copy link
Owner

FWIW I'm happy to add actions in the relevant places if you want to piggyback the existing hooks and exclusions in this plugin.

@kurund
Copy link
Author

kurund commented Jan 22, 2021

@christianwach Thanks for the quick response, will check and let you know.

@michaelmcandrew
Copy link

@christianwach one could argue that you do the thinking about data loss before you delete the event in CiviCRM. Or is there other data / things that I am not thinking about.

Would you be up for us adding a setting to the extension as an alternative approach to adding actions?

@christianwach
Copy link
Owner

Or is there other data / things that I am not thinking about.

@michaelmcandrew It depends on where your canonical data resides. If CiviCRM Events are the source of your canonical data, then sure, deleting EO Events when CiviEvents are deleted makes sense. If your source data resides in EO (with CiviCRM in the background, so to speak) then deleting the CiviCRM Event can, for example, be done in order to regenerate it on the next save of the EO Event. Any delete process also has to consider what happens when EO Repeating Schedules are modified and the "Delete unused CiviEvents" checkbox is checked.

Would you be up for us adding a setting to the extension as an alternative approach to adding actions?

I'm happy to consider a setting - or, more likely, a group of settings - if they respect the complexity of the issue and work for everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants