-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite readme mixin example to use Higher Order Component #395
Comments
Ah, yes! This has been on my todo list for a long time. |
@aesopwolf and @morenoh149 any progressive with this ? If not, I could help with this! |
@Jareechang I'd submit a quick PR and link here a gist. I'm sure 20 other folks would appreciate it even if the maintainers choose never to change the readme. Sadly I've lost the context I had when I opened this issue 😛 |
@morenoh149, ok. I'll go ahead and do that 😄. up to date documentation / examples = ❤️ for developers! |
@Jareechang I haven't made an progress with this. I'll gladly accept a PR though! |
With the announced changes in v16 this will become a more pressing topic https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html |
Sorry for being late on this one. I am currently updating the DOCS and examples with new syntax which hopefully would help! PR coming soon, stay tuned peeps! |
if anyone is interested is still stuck on how to convert away from using mixins, see my PR at #449. It provides an example of this. Feel free to reach out to me if you are stuck. |
This issue has been SOLVED in the new |
Hello, I see the readme demonstrates how to build a form element. However it utilizes the
mixins
field.Now that mixins are considered harmful would a rewrite of the example in the readme be welcome?
The text was updated successfully, but these errors were encountered: