Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 chore (AMP): Drop amp-addthis extension and components #47

Open
3 tasks
chriskyfung opened this issue Jan 9, 2024 · 0 comments
Open
3 tasks

🔥 chore (AMP): Drop amp-addthis extension and components #47

chriskyfung opened this issue Jan 9, 2024 · 0 comments
Labels
deprecation Notices about features or methods that will be removed in the future

Comments

@chriskyfung
Copy link
Owner

chriskyfung commented Jan 9, 2024

Description

The amp-addthis extension is no longer maintained and has been deprecated. It is recommended to drop this extension and its associated components from the codebase for the following reasons:

  • Maintenance Burdens: The extension is no longer actively maintained, which can lead to technical issues and security vulnerabilities.
  • Performance Impact: The extension can introduce performance overhead to AMP pages, which can negatively impact user experience.
  • Lack of Support: The extension is not supported by any major AMP framework or library, making it difficult to integrate and debug.

Proposed Changes

  • Remove the amp-addthis configuration from the Jekyll theme's _config.yml file.
  • Delete all references to the extension and its components from the theme's codebase.
  • Update the theme's documentation to reflect the removal of this extension.

Benefits

  • Improved performance and reliability of AMP pages.
  • Reduced maintenance burden.
  • Simplified codebase and improved extensibility.

Timeline

This change should be implemented within the next release of the Jekyll theme.

Additional Notes

  • Users who rely on the amp-addthis extension will need to find alternative methods for adding social sharing buttons to their AMP pages.
  • There are several other AMP-compatible social sharing extensions available, such as AMP-Social-Share and AMP-Story-Sharing.
  • Please provide feedback and suggestions on this proposed change.
@chriskyfung chriskyfung added the dependencies Pull requests that update a dependency file label Jan 9, 2024
@chriskyfung chriskyfung changed the title 🔥 Drop all <amp-addthis> components 🔥 feat (ui): drop all <amp-addthis> components Jan 16, 2024
@chriskyfung chriskyfung changed the title 🔥 feat (ui): drop all <amp-addthis> components 🔥 chore (AMP): Drop AMP-AddThis Extension and Components Mar 11, 2024
@chriskyfung chriskyfung changed the title 🔥 chore (AMP): Drop AMP-AddThis Extension and Components 🔥 chore (AMP): Drop amp-addthis extension and components Mar 11, 2024
@chriskyfung chriskyfung added deprecation Notices about features or methods that will be removed in the future and removed dependencies Pull requests that update a dependency file labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Notices about features or methods that will be removed in the future
Projects
None yet
Development

No branches or pull requests

1 participant