Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bugs in train.py #33

Closed
thangvubk opened this issue Apr 24, 2020 · 1 comment
Closed

Possible bugs in train.py #33

thangvubk opened this issue Apr 24, 2020 · 1 comment

Comments

@thangvubk
Copy link

Thank you for a very nice project.
When scanning through lib/train.py, I found two possible bugs:

  1. L#78 coords[:, :3] += (torch.rand(3) * 100).type_as(coords) should be coords[:, 1:] += (torch.rand(3) * 100).type_as(coords) since first coords is the batch index
  2. L#83 input[:, 1:] = input[:, 1:] / 255. - 0.5 should be input[:, :3] = input[:, :3] / 255. - 0.5
@chrischoy
Copy link
Owner

Thanks for reporting the error. I've pushed the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants