Fix race condition in logOut. Fixes jaredhanson#1004

chr15m · Sep 19, 2023 · 2bc7b35 · 2bc7b35
1 parent cfdbd4a
commit 2bc7b35
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/lib/sessionmanager.js b/lib/sessionmanager.js
@@ -86,8 +86,15 @@ SessionManager.prototype.logOut = function(req, options, cb) {
       }
       if (options.keepSessionInfo) {
         merge(req.session, prevSession);
+        req.session.save(function(err) {
+          if (err) {
+            return cb(err);
+          }
+          cb();
+        }
+      } else {
+        cb();
       }
-      cb();
     });
   });
 }