-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow createElement to return DocumentFragment? #91
Comments
Open to ideas. I've been brainstorming the use of weakmaps as way to avoid having to look at the DOM too. |
It may be easier to write a different component class to start out with. But also open to changes landing here. |
I've been considering a fresh start based on things I've learned the last couple years since we started the nanocomponent journey. Maybe... the time has come. |
yep just took a look at hui earlier today |
A few others I've been looking at too: https://github.com/Polymer/lit-element |
I have been using lit-element for a while and it is pretty cool. Also Beaker has been rebuild using lit-element |
or choo-hooks ;) |
nanohtml
now supports document fragments, which are very handy for returning a collection of siblings without having to wrap them in an arbitrary element.However
nanocomponent
is not currently designed to handle this.If we modify the
el instanceof window.Element
assert in_handleRender
to also acceptwindow.DocumentFragment
, we encounter an error because nanocomponent is trying to brand the returned node (which isn't a node).This also complicates proxying and many other things. I'm not sure how much of a rewrite this would require, but I do think it would be nice to support this feature.
Thoughts?
The text was updated successfully, but these errors were encountered: