Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse Interface State Arrays #381

Open
bcaddy opened this issue Mar 13, 2024 · 0 comments
Open

Reuse Interface State Arrays #381

bcaddy opened this issue Mar 13, 2024 · 0 comments
Labels
enhancement Optimization refactor for code that is functional but needs to be refactored

Comments

@bcaddy
Copy link
Collaborator

bcaddy commented Mar 13, 2024

Per an offline discussion with @evaneschneider.

We don't actually need three sets of interface state array (left/right for x, y, and z). We really only need one left/right pair then we can reconstruct in x, riemann solve in x, and repeat for y and z. This should reduce GPU memory usage by about 33% since the interface arrays account for ~50% of memory usage in my recent testing.

@bcaddy bcaddy added enhancement refactor for code that is functional but needs to be refactored Optimization labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Optimization refactor for code that is functional but needs to be refactored
Projects
None yet
Development

No branches or pull requests

1 participant