Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move location of temperature floor #362

Open
evaneschneider opened this issue Jan 10, 2024 · 0 comments
Open

Move location of temperature floor #362

evaneschneider opened this issue Jan 10, 2024 · 0 comments
Labels
enhancement refactor for code that is functional but needs to be refactored

Comments

@evaneschneider
Copy link
Collaborator

Right now the temperature floor is applied as a kernel call at the very end of each hydro integrator. I propose that instead, it be added as a single function call in the Grid3D::Update_Hydro_Grid function. If added right after the current Execute_Hydro_Integrator function, it shouldn't change the existing logic at all, but would reduce the number of function calls significantly (and allow it to be used for 1D and 2D simulations, a functionality that is currently missing.) This would require adding a new wrapper (host) function to call the kernel (as was done for other functions that were moved out of the integrators, e.g. cooling or the time step calculation).

@evaneschneider evaneschneider added enhancement refactor for code that is functional but needs to be refactored labels Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement refactor for code that is functional but needs to be refactored
Projects
None yet
Development

No branches or pull requests

1 participant