Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPU_TIME reduction #328

Open
alwinm opened this issue Sep 7, 2023 · 2 comments
Open

CPU_TIME reduction #328

alwinm opened this issue Sep 7, 2023 · 2 comments

Comments

@alwinm
Copy link
Collaborator

alwinm commented Sep 7, 2023

Currently the time reduction uses MPI_Allreduce simply because some reduction routines already existed in mpi_routines.h

This performs an extra unnecessary step of sending the result back out to all procs, but I believe only proc 0 needs the reduced data. MPI_Reduce should suffice.

@bcaddy
Copy link
Collaborator

bcaddy commented Sep 7, 2023

With some refactoring this could also be an asynchronous call, no need for the result until the next time that timer is called.

@bcaddy
Copy link
Collaborator

bcaddy commented Dec 15, 2023

FYI, the average reduction OneTime::End actually does need to be an allreduce since it's used to check if that rank is particularly slow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants