Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added explicit parameter to control number of function evaluations #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mikhailkin
Copy link
Contributor

No description provided.

@cynthia
Copy link
Collaborator

cynthia commented Jun 4, 2019

I'll have to think about the implications regarding this patch; in particular I don't know if this would break any downstream bindings that might break due to this due to expectations on the shape of lbfgs_parameter_t. At least #11 will be affected, but I'm suspecting other out of tree bindings will also be affected by this.

@cynthia cynthia self-requested a review June 4, 2019 11:56
@cynthia cynthia mentioned this pull request Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants