Better error handling for model files loading #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix memory access past allocated size; * return early if the model file doesn't start with FILEMAGIC (to prevent incorrect interpretation of data).
|
There are similar issues in |
chokkan
pushed a commit
that referenced
this pull request
Jan 24, 2016
+ Partially incorporated Pull Request #24.
|
Thanks for looking into it! Some context: these fixes were to fix segfaults I found writing tests for https://github.com/tpeng/python-crfsuite. Some of issues are worked around in a python-crfsuite wrapper (e.g. here), but it is still possible to cause a segfault (e.g. see these tests). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two improvements in this PR: