Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move non-alchemical REST system code to openmmtools #1187

Open
zhang-ivy opened this issue Apr 21, 2023 · 0 comments
Open

Move non-alchemical REST system code to openmmtools #1187

zhang-ivy opened this issue Apr 21, 2023 · 0 comments

Comments

@zhang-ivy
Copy link
Contributor

zhang-ivy commented Apr 21, 2023

I just wrote the following tutorial for creating non-alchemical REST systems using OpenMM: openmm/openmm-cookbook#17

The tutorial was written based off of RESTCapableHybridTopologyFactory (builds a REST-capable alchemical system) and RESTTopologyFactory (builds a REST-capable vanilla, non-alchemical system), pulling in the best parts of both. I did not write the tutorial solely based on RESTTopologyFactory because there are some parts of it that could be improved upon (based on lessons learned from writing RESTCapableHybridTopologyFactory).

I think eventually we'd want to remove RESTTopologyFactory (and related objects: RESTState, RESTProtocol) from perses, and introduce the objects defined in the openmm cookbook tutorial to openmmtools. The rationale for removing the code from perses and introducing it to openmmtools is because the code does not involve any alchemy and it is general enough to not rely on anything else in perses.

Note that we'd also have to remove the tests for RESTTopologyFactory from perses and introduce modified versions of the tests in openmmtools.

@ijpulidos ijpulidos added this to the 0.11.0: New top-level API milestone May 8, 2023
@ijpulidos ijpulidos moved this to Planned in Perses-OpenFE roadmap Nov 6, 2023
@ijpulidos ijpulidos moved this from Planned to Spring - Todo in Perses-OpenFE roadmap Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Spring - Todo
Development

No branches or pull requests

2 participants