Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue getter functions should work with automapping turned off / be language independent #198

Open
equada opened this issue Nov 18, 2021 · 1 comment
Labels

Comments

@equada
Copy link

equada commented Nov 18, 2021

In my opinion automapping is a bad idea because the array returned from the api is keyed by fixed keys, for example "resolutiondate".
In english the key is then automapped/changed to "Resolutiondate" but labels are always subject to change, maybe jira changes it to "Resolution Date" in a future release, or maybe the labels are configurable.
That would mean the getResolutionDate getter would be broken.

The actual problem: our Jira is in german, so the fields get automapped to the german field name.
That means if automapping is turned on, getResolutionDate doesn't find a field named "Resolutiondate" in the fields array.
If automapping is turned off via the options, the field is named "resolutiondate" and it also cannot get a field called "Resolutiondate"

Basically the getters only work if you have automapping turned on and your jira happens to be in english.

@aik099
Copy link
Collaborator

aik099 commented Nov 18, 2021

Thanks for finding this out. Would you please send a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants