Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Template refactoring #155

Open
mialondon opened this issue Oct 20, 2013 · 0 comments
Open

Template refactoring #155

mialondon opened this issue Oct 20, 2013 · 0 comments

Comments

@mialondon
Copy link
Contributor

I'll assign it to @rlskoeser in the first instance and @amandavisconti can pick up the javascript and other bits as and when time allows...

This issue is taken from discussion on #131 particularly
#131 (comment)
'The validation errors are minor, but the template page is a mess. I fixed a couple of validation errors, but trying to fix the button tag inside the a tag at the bottom of the results messed up the styles more than I wanted to deal with at the time (especially since it was clearly not causing the COinS issues).

The template has multiple sections that are commented, out, several blocks of javascript that should probably be pulled out and grouped together in a single external js file if we can, etc.'

It might also be worth referring to and updating the Serendipomatic architecture doc https://github.com/chnm/serendipomatic/wiki/Serendipomatic-architecture and checking for requirements that might emerge from 'Wishlist items and future development road map' https://github.com/chnm/serendipomatic/wiki/Wishlist-items-and-future-development-road-map

@ghost ghost assigned rlskoeser Oct 20, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants