Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf]: use bytes instead of hex for platform communication #1059

Open
chipweinberger opened this issue Nov 22, 2024 · 2 comments
Open

[Perf]: use bytes instead of hex for platform communication #1059

chipweinberger opened this issue Nov 22, 2024 · 2 comments
Labels
feature Feature request

Comments

@chipweinberger
Copy link
Owner

chipweinberger commented Nov 22, 2024 •
edited
Loading

What is your feature request?

In FBP, we we use hex strings for platform communication

Android: hexToBytes, bytesToHex
iOS: convertHexToData,convertDataToHex

We should instead switch to raw bytes, and convert to hex only when we log.
@chipweinberger chipweinberger added the feature Feature request label Nov 22, 2024
@chipweinberger
Copy link
Owner Author

Anyone can implement this and open a PR if they want.

@chipweinberger
Copy link
Owner Author

PR: #1067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chipweinberger