Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format OpenTitan codebase with Verible SystemVerilog code formatter #748

Open
ghost opened this issue Apr 5, 2021 · 3 comments
Open

Format OpenTitan codebase with Verible SystemVerilog code formatter #748

ghost opened this issue Apr 5, 2021 · 3 comments
Labels
formatter Verilog code formatter issues opentitan

Comments

@ghost ghost added the formatter Verilog code formatter issues label Apr 5, 2021
@ghost ghost self-assigned this Apr 5, 2021
@hzeller
Copy link
Collaborator

hzeller commented Apr 5, 2021

(If there are parse errors, there is one open pull request #697 that works on one parsing issue, not sure if this is one that is problematic here)

@hzeller
Copy link
Collaborator

hzeller commented Apr 6, 2021

Also as we had looked at before: relevant are these pull request, in which OpenTitan folks commented on the format output, which helps give us insight which is most important.

lowRISC/ibex#1215
msfschaffner/opentitan#7 (older)

Might be good if we can pair these comments with existing issues mentioned in https://github.com/google/verible/labels/formatter and increase priority as they are clearly needed.

@hzeller
Copy link
Collaborator

hzeller commented Apr 6, 2021

In this run I did a while back hzeller/opentitan@e28c2f6
David also added some links to existing bugs.

@ghost ghost added the opentitan label Jun 30, 2021
nikhiljha pushed a commit to nikhiljha/verible that referenced this issue Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatter Verilog code formatter issues opentitan
Projects
None yet
Development

No branches or pull requests

1 participant