-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] adding advanced search #1700
Comments
Searching the test result CSV with expressions makes a lot of sense (and is probably much easier than parsing the HTML table). So there we can have expressions such as Having logs or source code in a CSV might be pretty nasty as CSV is mostly meant for single item things with little spaces and certainly no newlines - otherwise a lot of (non-standardized) escaping is needed. The logs and source code is huge (many megabytes), so searching there without indexing might be pretty slow in JS, so this might be the time for some server-side solution, though that is not easy as right now we just have static content serving from github. Having some proof-of-concept to test if the amount of data is usable is probably good. It might be good to consider the use case in question: what are we looking for, and maybe the task gets easier. Somewhat unrelated to the original issue, but I think important for all these things: it should be possible to create a link out of it: with all search criteria added for the general table or the log files, this should result in a link that I can copy/paste e.g. in a mail or bug so that I can point other people directly to my finding. After all, we do the searching and narrowing down of the output for the very reason that we can look at it in a team and work on finding solutions to problems ("Check out how Verible is crashing with this message"). So most important - create a link that allows to re-create the resulting page for everyone. |
Thank you for taking the time to look into this and giving a detailed response. Would ElasticLunr be a better choice? |
Filtering by log content and source code. So I was wondering if it'd be a good idea to add the information in a CSV/JSON. The CSV would have 4 columns - tool, test, output/log, source code. The search query can be entered in the search box and will be used to search within the CSV using JS
The text was updated successfully, but these errors were encountered: