Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review files implementation #9

Open
rodber opened this issue Jun 27, 2023 · 0 comments
Open

Review files implementation #9

rodber opened this issue Jun 27, 2023 · 0 comments

Comments

@rodber
Copy link
Member

rodber commented Jun 27, 2023

Files are being hinted by Controller using ArrayTypeParameterInterface:

public static function acceptFiles(): ArrayTypeParameterInterface

This is limiting the design and not providing a clear type hint as it supports any ArrayType and it should work only with FileInterface parameters. The syntax should allow to define multiple files easily:

public static function acceptFiles()
{
    return files(
        photo: file(mime: 'image/jpeg'),
        signature: file(mime: 'application/pdf'),
    );
}

This requires a new array type for files, perhaps support for optional and required parameters. Similar to the other array shapes on Parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant