Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

Add 'Play a friend' button #7

Closed
programarivm opened this issue Jun 21, 2021 · 6 comments
Closed

Add 'Play a friend' button #7

programarivm opened this issue Jun 21, 2021 · 6 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@programarivm
Copy link
Member

programarivm commented Jun 21, 2021

When clicking the button, a popup should be displayed showing the user a link to be shared with a friend.

For further information please visit:

@CHuante
Copy link

CHuante commented Jun 22, 2021

hi, id like to call dibs and take a crack at this and contribute if its still around?

@programarivm
Copy link
Member Author

thank you @CHuante, I can't wait to see what you come up with!

@CHuante
Copy link

CHuante commented Jun 23, 2021

So for clarification, what should the button do? and where do you want it?

@programarivm
Copy link
Member Author

The button should be somehow similar to "Play with a friend" button at https://lichess.org.

It should be added to components/Button, which is a new component created a few hours ago.

For the sake of simplicity though we're creating a randomish token appended to an URL to be shared with a friend to play.

@programarivm programarivm self-assigned this Jun 24, 2021
@programarivm
Copy link
Member Author

@CHuante probably this issue is not too obvious since it implies some knowledge on the chess server actually. Sorry if it isn't a good first issue.

If this is okay with you, please feel free to write a comment on #10 so I can assign to you that one instead.

See isaacs/github#100

Thank you!

@programarivm programarivm removed the good first issue Good for newcomers label Jun 24, 2021
@programarivm
Copy link
Member Author

Merged PR #17

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants