[BUG] Artifactory Upload Erroneously Throwing Stove::Error::CookbookAlreadyExists

[ghost]

Attempting to perform an upload a new Chef Cookbook to Artifactory raises a Stove::Error::CookbookAlreadyExists. The logic seems to be guided by https://github.com/sethvargo/stove/blob/master/lib/stove/artifactory.rb#L18-L22.

Artifactory seems to throw a 403 when it encounters a Bad props auth token: and this case should not trigger this error message.

Steps to replicate are just to seemingly supply a bad token.

[biox]

+1 just used up a bunch of time troubleshooting this.

[belsander]

+1

[tyler-ball]

It seems to me the fix is, if the token is invalid, stove raises a Stove::Error::InvalidToken or similar error.