Communication per processor and over time functionality has been added #139
Conversation
| communicationMenuItem.setEnabled(true); | ||
| communicationVsTimeMenuItem.setEnabled(true); |
There was a problem hiding this comment.
This should be conditioned on the logs having a certain version, otherwise this will be broken for older logs.
| worker = new SwingWorker() { | ||
| public Object doInBackground() { | ||
| return null; | ||
| } | ||
| public void done() { | ||
| getData(); | ||
| setOutputGraphData(); | ||
| Checkbox cb = cbg.getSelectedCheckbox(); | ||
| setCheckboxData(cb); | ||
| thisWindow.setVisible(true); | ||
| thisWindow.repaint(); | ||
| } |
There was a problem hiding this comment.
This is almost exactly duplicated from the hasLogFiles() case, can they be combined?
| private double[] msg_count; | ||
| private double[] msg_size; | ||
| private double[] msg_recv_count; | ||
| private double[] msg_recv_size; | ||
| private double[] msg_recv_count_ext; | ||
| private double[] msg_recv_size_ext; |
There was a problem hiding this comment.
These should all be read as RLEBlocks to match the existing way of parsing SumDetail data.
| @@ -165,7 +171,177 @@ protected void read() | |||
| buildTable(TOTAL_TIME); | |||
| } else if (label.equals("EPCallTimePerInterval")) { | |||
| buildTable(NUM_MSGS); | |||
| } else { | |||
| } else if (label.equals("MsgSentCount")) { | |||
There was a problem hiding this comment.
This is all unnecessarily duplicated, it should all be using the same method with a parameter for each different type of data. As commented above, this should all be read as RLEBlocks like execution and call time already are, so ideally this should also be read in buildTable just as those are.
| public double[] getMsg_count() | ||
| { | ||
| return msg_count; | ||
| } | ||
|
|
||
| public double[] getMsg_size() | ||
| { | ||
| return msg_size; | ||
| } | ||
| public double[] getMsg_recv_count() | ||
| { | ||
| return msg_recv_count; | ||
| } | ||
|
|
||
| public double[] getMsg_recv_size() | ||
| { | ||
| return msg_recv_size; | ||
| } | ||
| public double[] getMsg_recv_count_ext() | ||
| { | ||
| return msg_recv_count_ext; | ||
| } | ||
|
|
||
| public double[] getMsg_recv_size_ext() | ||
| { | ||
| return msg_recv_size_ext; | ||
| } |
There was a problem hiding this comment.
Again, as stated earlier, these can use the existing getData method if they are read in as RLEBlocks.
| public double[][] getMsg_count() | ||
| { | ||
| return msg_count; | ||
| } | ||
|
|
||
| public double[][] getMsg_size() | ||
| { | ||
| return msg_size; | ||
| } | ||
| public double[][] getMsg_recv_count() | ||
| { | ||
| return msg_recv_count; | ||
| } | ||
|
|
||
| public double[][] getMsg_recv_size() | ||
| { | ||
| return msg_recv_size; | ||
| } | ||
| public double[][] getMsg_recv_count_ext() | ||
| { | ||
| return msg_recv_count_ext; | ||
| } | ||
|
|
||
| public double[][] getMsg_recv_size_ext() | ||
| { | ||
| return msg_recv_size_ext; | ||
| } |
There was a problem hiding this comment.
I think this can all be done via the existing getData function, see other comments.
| private double[][] msg_count; | ||
| private double[][] msg_size; | ||
| private double[][] msg_recv_count; | ||
| private double[][] msg_recv_size; | ||
| private double[][] msg_recv_count_ext; | ||
| private double[][] msg_recv_size_ext; |
There was a problem hiding this comment.
These should all be removed in favor of using rawData, see other comments.
| public double[][] getMsg_count() | ||
| { | ||
| return intervalData.getMsg_count(); | ||
| } | ||
| public double[][] getMsg_size() | ||
| { | ||
| return intervalData.getMsg_size(); | ||
| } | ||
| public double[][] getMsg_recv_count() | ||
| { | ||
| return intervalData.getMsg_recv_count(); | ||
| } | ||
| public double[][] getMsg_recv_size() | ||
| { | ||
| return intervalData.getMsg_recv_size(); | ||
| } | ||
| public double[][] getMsg_recv_count_ext() | ||
| { | ||
| return intervalData.getMsg_recv_count_ext(); | ||
| } | ||
| public double[][] getMsg_recv_size_ext() | ||
| { | ||
| return intervalData.getMsg_recv_size_ext(); | ||
| } |
There was a problem hiding this comment.
Indentation and style, try to use camelCase and avoid using _ in function/variable names if possible.
| for(int j =0;j<sentMsgCount_temp[i].length;j++){ | ||
| int curInt= j/numEPs ; | ||
| int curEP= j-curInt*numEPs; | ||
| curInt = (curInt * 1000)/numIntervals2; |
There was a problem hiding this comment.
Where is this 1000 coming from? What exactly is this trying to do? Resample the number of intervals in the logs to be 0-1000?
|
This will need to be changed for column major processing, instead of row major. |
No description provided.