Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace TableWriter with lipgloss table #254

Closed
bashbunni opened this issue Sep 1, 2023 · 3 comments · Fixed by #317
Closed

refactor: replace TableWriter with lipgloss table #254

bashbunni opened this issue Sep 1, 2023 · 3 comments · Fixed by #317
Assignees
@bashbunni
Labels
enhancement New feature or request

Comments

@bashbunni
Copy link
Member

Depends on this PR in Lipgloss charmbracelet/lipgloss#218
Would simplify the implementation of our current table rendering solution
@bashbunni bashbunni added the enhancement New feature or request label Sep 1, 2023
@bashbunni bashbunni self-assigned this Sep 1, 2023
@meowgorithm
Copy link
Member

meowgorithm commented Sep 1, 2023 •
edited
Loading

Lip Gloss table is pretty close, I think, so I imagine we can get it in not too long after Maas gets back. The width settings on the table actually came from the goal of implementing it into Glamour.

@maxmoehl
Copy link
Contributor

Would this help resolve #247 or is that a different issue?

@bashbunni
Copy link
Member Author

hey @maxmoehl this change should fix a lot of the issues currently have open for glamour tables. That one included

@bashbunni bashbunni linked a pull request Apr 4, 2024 that will close this issue
feat: render table with lipgloss #262
Closed
4 tasks
@caarlos0 caarlos0 mentioned this issue Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bashbunni bashbunni

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@meowgorithm @bashbunni @maxmoehl