Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to test ? #13

Open
asafyish opened this issue Dec 14, 2023 · 2 comments
Open

How to test ? #13

asafyish opened this issue Dec 14, 2023 · 2 comments

Comments

@asafyish
Copy link

I am working on a protocol that need to swap some tokens (relatively small amounts), I want those swaps to be permissionless, so using the milkman looks like a good idea, but I am missing 2 things:

  1. Some kind of callback notifying the swap was executed, can be called back even after a few hours.
  2. A way to test/simulate an executed trade, testing on a local network without solvers will never execute.

Do you have any suggestions how to tackle those issues ?

@burkaslarry
Copy link

Any updates so far? as I am the beginner on Solidity, what are the essential steps for me to land in this repo?

@charlesndalton
Copy link
Owner

Sure thing, apologies for delayed response!

Some kind of callback notifying the swap was executed, can be called back even after a few hours.

The milkman bot uses whether or not the tokens are still in the order contract to determine this

A way to test/simulate an executed trade, testing on a local network without solvers will never execute.

You can't simulate an executed trade for the reason you've mentioned, but you can get pretty close by verifying that Milkman will spit out the magic number (thus allowing the trade to be executed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants