Bump rest-client to 2.1.0 #83
Conversation
| rbody = response.body | ||
| if headers.keys.any? { |k| k.downcase == 'accept-encoding' } && rheaders[:content_encoding] == 'gzip' && rbody && !rbody.empty? | ||
| rbody = Zlib::GzipReader.new(StringIO.new(rbody)).read | ||
| end |
There was a problem hiding this comment.
Manually decode the gzipped response if Accept-Encoding header was manually set and response containts Content-Encoding: gzip.
loomchild
force-pushed
the
bump_rest_client_to_2_1_0
branch
from
301af0a
to
2aca08f
Compare
|
|
Please advise what to do with the above warning (I don't have access to detailed message, so it's not clear to me what is wrong) |
|
@cb-alish Please let me know if you need anything else regarding this patch (e.g. supporting deflate, reformating code, etc.) |
|
Hi @loomchild, my apologies for the delay in response. We'll look into this and come back with any questions / required changes later this. Thanks for your patience. |
|
Hi @loomchild (and others watching this), we're still looking into this and get back soon. While we're testing this, one of the approaches that we're thinking is to get rid of |
|
Hi @loomchild, could you take a look at #85 when you have a moment? We're transitioning to Net::HTTP with the goal of removing rest-client as a dependency. Just want to make sure everything looks good from your side. Thanks! |
|
I found an alternative solution, so I am no longer waiting for this PR. Unfortunately, I won't find the time right now to test your new solution. Feel free to drop it if it's no longer useful. |
Allow rest-client dependency 2.1.0.
Closes #55
Related to #43 and #50