Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

Incompatibility upgrading to 1.2.0 from 1.1.1 #894

Open
embs opened this issue Nov 10, 2016 · 3 comments
Open

Incompatibility upgrading to 1.2.0 from 1.1.1 #894

embs opened this issue Nov 10, 2016 · 3 comments

Comments

@embs
Copy link

embs commented Nov 10, 2016

Hi!

My project depends on Chaplin through following line (within package.json):

"chaplin": "^1.0.1"

Which I think tells npm to install the newest Chaplin version that is compatible with version 1.0.1.

But npm install installs version 1.2.0, which results in following errors when I try to build the project:

$ gulp javascripts
[22:48:47] Using gulpfile ~/trustvox.js/Gulpfile.js
[22:48:49] Compile error: TypeError: Path must be a string. Received 1
[22:48:49] Finished 'javascripts' after 2.52 s
[22:48:49] Compile error: Error: Cannot find module './chaplin/application' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './chaplin/composer' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './chaplin/dispatcher' from '/root/trustvox.js/node_modules/chaplin'                                                                                                               [6/1826]
[22:48:49] Compile error: Error: Cannot find module './chaplin/controllers/controller' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './chaplin/lib/composition' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './chaplin/lib/event_broker' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './chaplin/lib/history' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './chaplin/lib/route' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './chaplin/lib/router' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './chaplin/lib/support' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './chaplin/lib/sync_machine' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './chaplin/lib/utils' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './chaplin/mediator' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './chaplin/models/collection' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './chaplin/models/model' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './chaplin/views/collection_view' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './chaplin/views/layout' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './chaplin/views/view' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './composer' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './dispatcher' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './lib/router' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './views/layout' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './lib/event_broker' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './mediator' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './lib/composition' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './lib/event_broker' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './mediator' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module '../mediator' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module '../lib/event_broker' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module '../lib/utils' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './lib/event_broker' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './lib/utils' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './mediator' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './event_broker' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module '../mediator' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './event_broker' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './utils' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module '../controllers/controller' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './event_broker' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './history' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './route' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './utils' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module '../mediator' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module '../mediator' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module '../mediator' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './lib/utils' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './model' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module '../lib/event_broker' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module '../lib/utils' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module '../lib/event_broker' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './view' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module '../lib/utils' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module './view' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module '../lib/event_broker' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module '../lib/utils' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module '../mediator' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module '../lib/event_broker' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module '../lib/utils' from '/root/trustvox.js/node_modules/chaplin'
[22:48:49] Compile error: Error: Cannot find module '../mediator' from '/root/trustvox.js/node_modules/chaplin'

The build completes successfully when I force Chaplin version 1.1.1.

My questions is: are these versions really compatible?

Thanks!

@Florian-R
Copy link
Contributor

I'm pretty sure it comes from 1941d53, which switched from urequire to browserify.

This also causes brunch/brunch#1517

@shvaikalesh Sorry to ping you but maybe you could confirm that?

@shvaikalesh
Copy link
Contributor

shvaikalesh commented Nov 14, 2016

Hey @Florian-R, thanks for triaging this.

I think Chaplin should move from CommonJS to ES6 modules with Rollup now that CoffeeScript supports them. This will reduce bundle size and reduce exports.stuff = stuff = expressions to export stuff =, which is nice.

For now, please use unbundled version from GitHub as a workaround.

PS. Feel free to ping me anytime, here or on Gitter, regarding Brunch or Chaplin or other stuff.

@Florian-R
Copy link
Contributor

Thanks @shvaikalesh. I'll should have some time free this week, I'll try to do the switch to rollup and send a PR if possible.

@Florian-R Florian-R mentioned this issue Nov 16, 2016
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants