You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the GitlabOcean gets initialised and get_perceval_params_from_url is called, the 'groupname' from the URL gets lost. As a result, all the future interactions that try to 'rebuild' the URL and/or the API URL get a 404 error as they build the following URLs, which don't exist:
https://my.gitlab.instance.internal.com/subgroupname/projectname or https://my.gitlab.instance.internal.com/api/v4/projects/subgroupname%2Fprojectname
I've hacked in a fix by replacing this line in grimoire_elk/raw/gitlab.py:
In any case, I think we should be perhaps be preserving the / characters, and then when the url gets assembled passing the owner through a urllib.parse.quote('/', safe='') call.
The text was updated successfully, but these errors were encountered:
StingRayZA
added a commit
to StingRayZA/grimoirelab-perceval
that referenced
this issue
Nov 3, 2020
This allows us to retain the '/' separation of URL pieces in any gitlab
urls that have been stored in the object. This change also lays the
groundwork for a fix in the -elk repository to allow multiple nested
gitlab group layers in gitlab URLs.
See also: chaoss/grimoirelab-elk#946
Signed-off-by: Raimund Hook <[email protected]>
Hi
(apologies if this should rather be logged at https://github.com/chaoss/grimoirelab-perceval)
I have a gitlab site URL that looks something like this:
https://my.gitlab.instance.internal.com/groupname/subgroupname/projectname
When the
GitlabOcean
gets initialised andget_perceval_params_from_url
is called, the 'groupname' from the URL gets lost. As a result, all the future interactions that try to 'rebuild' the URL and/or the API URL get a 404 error as they build the following URLs, which don't exist:https://my.gitlab.instance.internal.com/subgroupname/projectname
orhttps://my.gitlab.instance.internal.com/api/v4/projects/subgroupname%2Fprojectname
I've hacked in a fix by replacing this line in
grimoire_elk/raw/gitlab.py
:with this:
In any case, I think we should be perhaps be preserving the
/
characters, and then when the url gets assembled passing the owner through aurllib.parse.quote('/', safe='')
call.The text was updated successfully, but these errors were encountered: