Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Improve Cloud Chaos Providers #46

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

miketonks-form3
Copy link

@miketonks-form3 miketonks-form3 commented Jun 15, 2023

Initial thoughts about improving the support for chaos experiments using cloud providers infrastructure.

preview

@chaotic-prow
Copy link

chaotic-prow bot commented Jun 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

miketonks and others added 4 commits June 19, 2023 11:28
Signed-off-by: Mike Tonks <[email protected]>
Signed-off-by: Mike Tonks <[email protected]>
Signed-off-by: Mike Tonks <[email protected]>
Supported filters are defined in the AWS SDK. For details see:
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeInstances.html

### GCP Chaos selecting multiple instances using labels
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For GCP and Azure, could you provide the related docs like
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeInstances.html please? ❤️

Comment on lines 115 to 117
It might be necessary to make breaking changes to the structures, so it
in this case it would be easier to introduce new types and eventually
deprecate the old ones.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems only introducing new filters would NOT take breaking changes, it's fine. Or do I miss something?

Comment on lines 112 to 113
It might be necessary to introduce new chaos types e.g. AWSNetworkChaos,
GCPNetworkChaos and so on.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I prefer to introduce new chaos type, also in other words, new CRDs.

it's OK, and it is also one of the benefits that Chaos Mesh bring with declarative API: clear spec/status.

Signed-off-by: Mike Tonks <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants