Skip to content

Commit

Permalink
Merge pull request etcd-io#16750 from serathius/roundrobin-3.5
Browse files Browse the repository at this point in the history
[v3.5] Return to default write scheduler since golang.org/x/[email protected] started using round robin
  • Loading branch information
serathius authored Oct 12, 2023
2 parents c669e0c + 404eeaa commit 9776cec
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 0 additions & 2 deletions server/embed/serve.go
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,6 @@ func configureHttpServer(srv *http.Server, cfg config.ServerConfig) error {
// todo (ahrtr): should we support configuring other parameters in the future as well?
return http2.ConfigureServer(srv, &http2.Server{
MaxConcurrentStreams: cfg.MaxConcurrentStreams,
// Override to avoid using priority scheduler which is affected by https://github.com/golang/go/issues/58804.
NewWriteScheduler: http2.NewRandomWriteScheduler,
})
}

Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/watch_delay_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ var tcs = []testCase{
{
name: "TLS",
config: etcdProcessClusterConfig{clusterSize: 1, isClientAutoTLS: true, clientTLS: clientTLS},
maxWatchDelay: 3 * time.Second,
dbSizeBytes: 500 * Kilo,
maxWatchDelay: 150 * time.Millisecond,
dbSizeBytes: 5 * Mega,
},
{
name: "SeparateHttpNoTLS",
Expand Down

0 comments on commit 9776cec

Please sign in to comment.