Improve ParseIndexError::InvalidCharacter
error
#94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #80 I introduced a new error variant to capture cases where the array index starts with
+
(which is valid forusize
representations in Rust, but not valid for array indices per RFC 6901).As I noted here, keeping a collection of invalid characters in the error variant is overkill, since the accepted domain of
usize::parse
is very unlikely to evolve, as that'd be a breaking change instd
. According to the docs+
is the only accepted non-digit character, so we don't need to expect any others.I'm not specialising the variant name for
+
though to leave some room for later adopting a different parser that has different domain (unlikely as that is) or in the off chancestd
does change this API. The error message changing isn't a hard break, if we ever need to update it in the future, so I'm keeping it more specific to make it more useful.