Added DataStore that keep data on browser storage. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed `LocalDataStore` names to `MockDataStore` for add new `LocalDataStore`. Before `LocalDataStore` store data on memory, so I think the name `MockDataStore` is more appropriate than `LocalDataStore`.
azuchi
requested changes
Aug 25, 2023
yarn.lock
Outdated
There was a problem hiding this comment.
This repository already has package-lock.json. It is undesirable to have two lock files.
There was a problem hiding this comment.
Will remove yarn.lock. thanks.
src/data_store/mock_data_store.js
Outdated
| * | ||
| * This DataStore is very simple store that save any data in flush memory. | ||
| */ | ||
| class MockDataStore { |
There was a problem hiding this comment.
The word Mock is a misnomer because it reminds us of test mocks. MemoryStore or similar would be appropriate.
Yamaguchi
requested changes
Aug 25, 2023
# Conflicts: # src/data_store.js # ts_src/data_store.ts # types/data_store.d.ts
Runed `npm upgrade`. Because `npm install` failed in my local.
…ck` word is misleading.
Co-authored-by: Yamaguchi <[email protected]>
…ge_data_store # Conflicts: # package-lock.json
…' into feature/local_storage_data_store
Added `npm run format` in build script for helpful.
@Yamaguchi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented new
LocalDataStorethat store data on browser storage usingwindow.localStorage.Changed
LocalDataStorenames toMockDataStorefor add newLocalDataStore. Before'sLocalDataStorestore data on memory, so I think the nameMockDataStoreis more appropriate thanLocalDataStore.