Skip to content

Commit

Permalink
Merge pull request #199 from azuchi/custom-cov-handle
Browse files Browse the repository at this point in the history
Move coverage threshold to spec_helper
  • Loading branch information
rantan authored Jan 10, 2024
2 parents 1611d5a + 2f1dc0b commit 0a67728
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 12 deletions.
15 changes: 3 additions & 12 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,8 @@

name: Ruby

on:
push:
branches: [master, v1.1, v1.2]
pull_request:
branches: [master, v1.1, v1.2]
on: [push,pull_request]

jobs:
test:
runs-on: ubuntu-latest
Expand All @@ -30,10 +27,4 @@ jobs:
ruby-version: ${{ matrix.ruby-version }}
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
- name: Run tests
run: bundle exec rake
- name: SimpleCov+ Action
uses: joshmfrankel/simplecov-check-action@main
with:
minimum_suite_coverage: 99
minimum_file_coverage: 70
github_token: ${{ secrets.GITHUB_TOKEN }}
run: bundle exec rake
2 changes: 2 additions & 0 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

SimpleCov.start do
add_filter '/spec/'
SimpleCov.minimum_coverage 99
SimpleCov.minimum_coverage_by_file 70
end

RSpec.configure do |config|
Expand Down

0 comments on commit 0a67728

Please sign in to comment.