Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about quantile huber loss function in IQN #590

Open
ShogoAkiyama opened this issue Jan 28, 2020 · 1 comment
Open

Question about quantile huber loss function in IQN #590

ShogoAkiyama opened this issue Jan 28, 2020 · 1 comment
Labels

Comments

@ShogoAkiyama
Copy link

Hello, I have one question.
In the paper of IQN, quantile huber loss function is delta_{ij} < 0.

Screen Shot 2020-01-28 at 18 34 45

But chainerrl iqn code is delta_{ij} > 0.
I think this inequlity sign is not correct.

I’m sorry for poor English.

@muupan
Copy link
Member

muupan commented Jan 28, 2020

Wow, good catch! The sign seems not correct. Thank you for reporting it.

If I understand correctly, tau in the paper actually corresponds to 1-tau in ChainerRL's IQN, because
|tau - I_{delta<0}| = |tau - (1 - I_{delta>=0})| = |(1 - tau) - I_{delta>=0}| (and if delta=0 then loss is 0 anyway). As long as quantile thresholds are sampled from U([0,1]), it should not affect its behavior as an RL algorithm, but the meaning of tau is the opposite. It should be fixed.

@muupan muupan added the bug label Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants