Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello #7

Open
Nakilon opened this issue Sep 26, 2022 · 3 comments
Open

Hello #7

Nakilon opened this issue Sep 26, 2022 · 3 comments

Comments

@Nakilon
Copy link

Nakilon commented Sep 26, 2022

May I wonder what didn't work for you in dhash-vips?
Is it because Nakilon/dhash-vips#12 kept erroring on ARM?

@Nakilon
Copy link
Author

Nakilon commented Sep 26, 2022

And a note: since you've also switched from idhash to dhash the quality of comparison can degrade a little.

@cguess
Copy link
Owner

cguess commented Sep 26, 2022

@Nakilon correct, at least at the time ARM was breaking so it made it impossible to test during development on my MacBook Pro M1's. I haven't gone back and looked further however since this is working quite well for the moment.

Thank you for the tip on the algorithm, I may take some time in the next few weeks to update.

If you'd like me to help with anything just let me know.

@Nakilon
Copy link
Author

Nakilon commented Sep 26, 2022

IIRC it was weird that it has compiled the extension but it didn't see the methods it had to have.
Not sure what was going on there but probably there is some simple ruby way to add some --without-extension option passable to gem install or Gemfile so you could just force it to skip trying to build the extensions and fallback to ruby implementation. It was meant to be able to doctor itself for the compilation errors but the error is weird.

Is it still failing? Probably ruby and macos had some updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants