Remove add_row
function from Matrix
#59
Labels
high priority
Should be fixed as a next course of action
performance
Could make things faster/use less memory
rustiness
Make code more rusty - sometimes may improve performance
I am really not a fan of adding rows to matrices for three reasons:
0 x 0
matrix should not be a special case (it is after all still a linear map from the 0D vector space to itself).n x m
matrix and keep track of how many rows you have set. If you are really only interested in a list of vectors, this can also be kept as a[Vec<i64>]
or aVec<Vec<i64>>
(note a list of vectors is conceptually different from a matrix)Temperely-Lieb-Jantzen/src/matrix.rs
Lines 94 to 115 in 63abdc2
The text was updated successfully, but these errors were encountered: