Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic rendering #186

Merged
merged 16 commits into from
Apr 12, 2024
Merged

Dynamic rendering #186

merged 16 commits into from
Apr 12, 2024

Conversation

johannesugb
Copy link
Member

Opened a preliminary pull request for reviewing

auto_vk_toolkit/src/context_vulkan.cpp Outdated Show resolved Hide resolved
examples/dynamic_rendering/shaders/color.frag Outdated Show resolved Hide resolved
examples/dynamic_rendering/shaders/screen_space_tri.vert Outdated Show resolved Hide resolved
auto_vk_toolkit/src/context_vulkan.cpp Outdated Show resolved Hide resolved
MatejSakmary and others added 5 commits November 13, 2023 15:21
- local variables to lowerCamelCase
- remove artefacts of old versions
- missing newline at the end of shaderfiles

Co-authored-by: Johannes Unterguggenberger <[email protected]>
- Changed the way split is defined
- Deleted duplicit files for visual studio examples
- Removed redundant check in dynamic rendering support
- Renamed "renderpass" to "draw"/"pass"
…to use renderpass_reference() again instead of renderpass_pointer()
Copy link
Member Author

@johannesugb johannesugb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuf!

@MatejSakmary
Copy link
Collaborator

I have added MSAA to the new example (to test the API etc...). I have not found any other example using MSAA and I though it might be nice to have at least one, however I can remove it if you don't like it.

@johannesugb johannesugb merged commit f5d429f into development Apr 12, 2024
6 checks passed
@johannesugb johannesugb deleted the dynamic_rendering branch April 12, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants