-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tagline, Global eyebrow, and Global eyebrow actions #1797
Comments
I talked this over with @sonnakim and I have my next steps:
|
@sonnakim Another idea I have is to separate these into sections. I mocked up a flat structure for the left nav (just used the Chrome inspector). If we really did it, it would be alphabetized (not like what I show in the mock-up).
I think that at this point in time it would be quite helpful to remove the groupings from the components section (Alerts, Behavior, Form components, List and Tables). It is hard to come up with the right solution or even a stop gap solution while those are still in place. Is this something that we could prioritize? If not we will come up with a solution that makes sense within the React component library where we do have this flat structure and then do our best within the DS although that will mean having things like "Banner (US gov)" under "Alerts". Might you be open to removing the groupings at this point in time? |
For the record, @natalia-fitzgerald and I chatted, and I'm fine with removing those groupings. I don't think it should be a controversial move, but we can always restore them if that's the case. |
@sonnakim I noticed that the groupings label (eyebrow) is still showing up on the individual component pages. A temporary workaround could be to add a grouping label for the entire section. The first thing I thought of was "Components by type." It's a little redundant and it would be better if it were one word so I would be open to something else. Let me know what you think of this workaround and, if you'd like to go with it, what wording you would prefer. In the mock-ups I used "Component" as a placeholder. The alternative is that we just leave the legacy eyebrows for now as we wait for the technical fix to remove the level all together. Here's what we have now and what the groupings label could look like if we choose to go that route as a temporary fix:
In doing this I did notice that we don't have a link styling change or visual indicator in the left nav to indicate the current page a user is on. I opened a separate issue for this so as not to distract from the purpose of this specific issue. Here's a link to that issue: #1809 For the Banner pages here's a possible approach to the page breakdowns. I think I'd prefer to go with Option 1 for the sake of consistency and simplicity but I did want to present the 2 options so that we can compare.
|
Changed eyebrow to "Components" - see #1797
Natalia and I chatted about this — she will use "Components" as a placeholder for the eyebrow. I'm going to remove the subsections for Patterns as well, so there too, when I do that work, I'll update the eyebrows on those pages to "Patterns". We'll then decide whether it makes sense to have an eyebrow at all if there are no subsections. Also I agree with the approach mocked up in Option 1 for the titles of the banner pages 👍 |
Hi @sonnakim Here's a link showing the label change in the left navigation: And here's a link showing the new wording for the Banner (notification) page and left navigation label. https://cfpb.github.io/design-system/components/banner-notification |
Thanks @natalia-fitzgerald. The eyebrows on individual component pages can be changed by editing the markdown file directly, rather than using the CMS. I've already done this on the radio buttons page — let me know if you'd like me to walk you through how that's done |
Hi @sonnakim As a next step we can determine whether we will add the |
Thanks @sonnakim. I have made these updates the component pages on the DS. The eyebrow is now "Components" for all components pages. |
Awesome, thanks! |
Here's where we landed.
All items here have been handled except for the question of the US gov banner (with links) ( |
As we continue our work on building the React component library we are currently working on adding the Tagline and Global eyebrow components.
Based on the SBL layouts we will need components that match:
a-tagline
m-global-eyebrow
m-global-eyebrow_actions
Existing components (CFPB DS and/or consumerfinance.gov)
a-tagline
Includes:
m-global-eyebrow
Includes:
m-global-eyebrow_actions
Includes:
Component naming
In thinking about the naming of these components I took a look at a few other federal government design systems to see how they handle these nearly identical components.
USWDS
Name: Banner
Name in code: usa-banner
usa-banner__header-text
and "usa-banner__header-flag" in the code.https://designsystem.digital.gov/components/banner/
Veteran's Affairs
Name: banner - official gov
Name in code: va-official-gov-banner
https://design.va.gov/components/banner/official-gov
If we decide to add
.m-global-eyebrow
as a component to the CFPB DS website we may want to consider either giving it a more descriptive name in the code (alluding to the usa, or official gov, or gov, etc) or, at least, giving it a name like this in the documentation site (leaving the names in code as-is).Questions:
m-global-eyebrow
andm-global-eyebrow_actions
to the CFPB Design System documentation site?@sonnakim for consultation and awareness
The text was updated successfully, but these errors were encountered: