Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid: Replace grid with CSS grid #1272

Open
anselmbradford opened this issue Aug 18, 2021 · 1 comment
Open

Grid: Replace grid with CSS grid #1272

anselmbradford opened this issue Aug 18, 2021 · 1 comment
Labels
Size: 5 Est. level of effort: 1=tiny, 5=enormous wontfix This will not be worked on

Comments

@anselmbradford
Copy link
Member

At some point we should migrate our grid to CSS grid to support model layout techniques https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Grid_Layout/Realizing_common_layouts_using_CSS_Grid_Layout#building_a_layout_using_the_12-column_system

@anselmbradford anselmbradford added the Size: 5 Est. level of effort: 1=tiny, 5=enormous label Aug 18, 2021
@sonnakim sonnakim changed the title Replace grid with CSS grid Grid: Replace grid with CSS grid Sep 25, 2023
@sonnakim
Copy link
Member

sonnakim commented Jul 11, 2024

We won't work on this —we'll be creating layouts using CSS grid and flexbox as we move towards using web components.

Some of this was done with the RTL work: layouts 2-1 and 1-3 were converted by Ans to use CSS grid. The only other template style we use extensively is the full layout. For this grid utility (as documented in the DS), Paying for College, Rate Explorer, and other one-off apps use the grid utility documented in the Design System, but Ans thinks doing layouts in this manner is brittle. As we move into a world where things are collections of components, the components themselves should handle their own layouts, so we'd want to think of grid utilities as deprecated — they're not intuitive to work with.

As we work on layout related issues, we should use flexbox or CSS grid, and minimize usage of the grid utility mixins.

@sonnakim sonnakim added the wontfix This will not be worked on label Jul 11, 2024
@sonnakim sonnakim moved this to Backlog in Active sprint board Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 5 Est. level of effort: 1=tiny, 5=enormous wontfix This will not be worked on
Projects
Development

No branches or pull requests

2 participants