Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Some comments about feature tests #116

Open
fzalila opened this issue Mar 27, 2020 · 2 comments · Fixed by #123
Open

Some comments about feature tests #116

fzalila opened this issue Mar 27, 2020 · 2 comments · Fixed by #123
Assignees
Milestone

Comments

@fzalila
Copy link
Contributor

fzalila commented Mar 27, 2020

Some comments:

  1. __tests__:
    1. some helpers defined in the test scripts do not seem to be used (ex loadUrl, waitForText, ...), are they necessary?
    2. nt4s url needs to be removed, this should preferably be a config variable somewhere (lib/config.js baseUrl?), you can use http://test.fadi.cetic.be as a placeholder.
    3. if possible, use the test case identifier in the filename instead of introducting a new numerotation
  2. provide examples in README.md
  3. Test-scripts-specifications.md :
    1. links should be relative, not absolute
    2. some links are missing
  4. Cockburns-specifications.md :
    • some links are missing
  5. remove remaining pgadmin references

Originally posted by @banzo in #107 (comment)

@fzalila fzalila changed the title Some comments: Some comments about feature tests Mar 27, 2020
@fzalila
Copy link
Contributor Author

fzalila commented Mar 30, 2020

@banzo
For 1.i the identified helpers can be used in other tests. So they are necessary.
d2b241e and 4586b93 resolve 1.ii and 2.
For 1.iii, yes it is possible but after resolving 3., 4. and 5.

@SellamiRami
can you please resolve 3., 4. and 5. issues.

@SellamiRami
Copy link

SellamiRami commented Jun 2, 2020

@banzo I resolved the issues number 3, 4 and 5.
In addition, I added the cockburn TC-6 and the test script TS-6 in order to consider the creation of a table using Adminer.
I think that everything is OK now.
Rami.

@banzo banzo assigned fzalila and unassigned SellamiRami Jun 3, 2020
@banzo banzo added this to the 0.1.2 milestone Jun 3, 2020
@banzo banzo linked a pull request Jun 3, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants