Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Configuration also clears defaults.conf #188

Open
tux78 opened this issue Dec 29, 2019 · 1 comment
Open

Clear Configuration also clears defaults.conf #188

tux78 opened this issue Dec 29, 2019 · 1 comment

Comments

@tux78
Copy link

tux78 commented Dec 29, 2019

When clicking "Clear Configuration" the defaults.conf is not loaded, thus the defaults.conf file will be empty once saving the cleared botnet. This can be fixed by modifying configs.js (function load_bots)

if (getUrlParameter("configuration") !== "new") {
    load_configuration();
} else {
    load_file(DEFAULTS_FILE, (config) => { app.defaults = read_defaults_conf(config) })
    draw();
    resize();
    $saveButton.blinking();
}

Adding the "load_file" statement correctly loads defaults.conf when clearing the botnet.

@ghost
Copy link

ghost commented Feb 3, 2020

Thanks for the report.

However, I think that clearing/resetting the defaults also might be useful.

What about two options:

  • "Clear configuration": rename maybe to "clear all bots" with the behavior you propose
  • And a new "Reset configuration" which resets the config to the shipped. That action could be performed by by intelmqctl in the backend (easier than with pure JS)

Could be done by a new modal dialog, so any of these actions require at least two (or more) clicks.

@ghost ghost added the help wanted label Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant