Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: remove error from CACerts() signature #12

Open
dolmen opened this issue Aug 29, 2018 · 3 comments
Open

v2: remove error from CACerts() signature #12

dolmen opened this issue Aug 29, 2018 · 3 comments

Comments

@dolmen
Copy link
Contributor

dolmen commented Aug 29, 2018

Parsability of the certificates should be checked by the unit test.
At runtime this check is supposed to have passed, so no error should occur in AppendCertsFromPEM and any error happening is a problem that should have been caught at build time of the program embedding gocertifi and reporting such error as panic would be appropriate.

@mattrobenolt
Copy link
Member

I do agree with this, but I'd rather not roll in and make a breaking API change right now. You are right though. :)

@mattrobenolt
Copy link
Member

59a85de is heading towards this direction.

@tmm1
Copy link
Contributor

tmm1 commented Sep 25, 2019

👍 This would make usage a lot simpler when setting up http clients/transports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants