-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow templating of labels/annotations on target configmaps/secrets #340
Comments
When looking into the Thus allowing us to inject the CA bundle from a secret that would have been created by Sorry for the inconvenience 🙏 |
In the end, the use of the annotation But the only thing missing for this feature to be achievable is to be able to add custom annotations on the secret created by the It would be nice to be able to add the |
It could make sense to add a feature similar to cert-manager secretTemplate. That should make the feature address more use cases, and not just this one specifically. It should also cover target configmaps if implemented. |
Issues go stale after 90d of inactivity. |
/remove-lifecycle stale |
@erikgb: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
When creating
ValidatingWebhookConfiguration
orMutatingWebhookConfiguration
, we can specify the CA bundle to use in theClientConfig
: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.25/#webhookclientconfig-v1-admissionregistration-k8s-ioHowever, those ressources doesn't allow to specify the CA bundle from a
Secret
orConfigmap
(only inline).cert-manager
tackles this problem by injecting the CA bundle on resources annotated withcert-manager.io/inject-ca-from: <namespace>/<certificate>
.So in order to provide the same functionality as
cert-manager
, it would be nice to introduce atrust-manager-ca-injector
that would be responsible to inject the CA bundle on resources annotated withtrust.cert-manager.io/inject-ca-from: <namespace>/<bundle>
.The text was updated successfully, but these errors were encountered: