Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for kubectl installation #301

Open
dprotaso opened this issue Feb 21, 2024 · 5 comments
Open

Add support for kubectl installation #301

dprotaso opened this issue Feb 21, 2024 · 5 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@dprotaso
Copy link

Not a fan that helm is required to generate yamls to be used with kubectl apply

@SgtCoDFish SgtCoDFish added this to the trust-manager v1 milestone Feb 21, 2024
@SgtCoDFish
Copy link
Member

Could you expand on what you dislike about this? Simply that there's an additional dependency?

I totally understand the ask; I think this would be a reasonable thing to add for a potential trust-manager v1, so I've added it to the milestone

@dprotaso
Copy link
Author

Could you expand on what you dislike about this? Simply that there's an additional dependency?

More or less.

Also for CI and testing it's nice to just kubectl apply -f ${some_release_yaml_link}

@erikgb
Copy link
Contributor

erikgb commented Feb 22, 2024

I think adding this could make sense. It will also simplify our setup. We try to avoid Helm as much as possible and prefer kustomize. A present we inflate the Helm chart into resources client-side before including it in a kustomization for further processing.

It could be implemented as a simple helm template using the chart default values - where the result is committed to Git. It might complicate the release process a bit, but I imagine it's doable. A benefit of this approach is a "smoke test" of Helm chart changes. I am assuming Helm will remain the master of resources.

@rajatvig
Copy link

The CRDs can no longer be downloaded standalone vs prior releases. Maybe a standalone yaml could be a release artifact?

@cert-manager-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale

@cert-manager-prow cert-manager-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants