Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Broken config when using commonLabels #162

Open
xunholy opened this issue May 20, 2024 · 0 comments
Open

Issue: Broken config when using commonLabels #162

xunholy opened this issue May 20, 2024 · 0 comments

Comments

@xunholy
Copy link

xunholy commented May 20, 2024

https://github.com/jetstack/google-cas-issuer/blob/59fa9efe63bf6d26ea7a833e4694c66045883017/deploy/charts/google-cas-issuer/templates/deployment.yaml#L16C7-L16C65

We use commonLabels to add consistent labels across all resources, in our case we're also using apps: for our own convention however, this line breaks because it adds it with the bespoke chartname.

This would be great if it could use the helper function and also ensure that all keypairs are unique otherwise we get the following errors:

Error: map[string]interface {}(nil): yaml: unmarshal errors:
  line 35: mapping key "app" already defined at line 29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant