Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support prometheus metrics #60

Open
2 tasks
7ing opened this issue Jan 16, 2024 · 1 comment · May be fixed by #73
Open
2 tasks

Support prometheus metrics #60

7ing opened this issue Jan 16, 2024 · 1 comment · May be fixed by #73
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@7ing
Copy link
Contributor

7ing commented Jan 16, 2024 •
edited
Loading

Similar to cert-manager controllers (https://cert-manager.io/docs/devops-tips/prometheus-metrics/#scraping-metrics), csi-lib should expose some key metrics for promethues to scrap, like:

  • CertificateRequest status (number issued, approved/denied, failed, etc) 
    certmanager_certificate_ready_status
  • Near expiry CertificateRequests (how many dates left to renew) 
    certmanager_certificate_expiration_timestamp_seconds

See related discussion in #51 (comment)
@inteon inteon added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Aug 29, 2024
@munnerz
Copy link
Member

munnerz commented Nov 4, 2024

+1 to this - a few other thoughts/ideas on what we could expose (non-exhaustive, so please add your own ideas!):

  1. a metric for "how many pods on this node that reference this CSI driver could be useful to understand what the driver 'knows'
  2. how many certificates we are 'managing' (which should match to (1), and would be an error/alert if it didn't)
  3. expiration time
  4. CertificateRequest terminal state reporting

7ing added a commit to 7ing/csi-lib that referenced this issue Nov 22, 2024
@7ing
Support prometheus metrics
c381e55 
certmanager_csi_certificate_request_expiration_timestamp_seconds
certmanager_csi_certificate_request_ready_status
certmanager_csi_certificate_request_renewal_timestamp_seconds
certmanager_csi_driver_issue_call_count
certmanager_csi_driver_issue_error_count
certmanager_csi_managed_certificate_count
certmanager_csi_managed_volume_count

fixes: cert-manager#60
Signed-off-by: Jing Liu <[email protected]>
@7ing 7ing linked a pull request Nov 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support prometheus metrics 7ing/csi-lib
3 participants
@munnerz @7ing @inteon